From bb998efecb99752c0d159aa77a49f84d80bd0252 Mon Sep 17 00:00:00 2001 From: Jan Beulich Date: Thu, 28 Apr 2016 15:08:54 +0200 Subject: [PATCH] x86/HVM: fix emulation re-issue check ?: has lower precedence than !=, hence parentheses are required here. Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper Release-acked-by: Wei Liu --- xen/arch/x86/hvm/emulate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/x86/hvm/emulate.c b/xen/arch/x86/hvm/emulate.c index cc0b84138b..1384a4234b 100644 --- a/xen/arch/x86/hvm/emulate.c +++ b/xen/arch/x86/hvm/emulate.c @@ -134,7 +134,7 @@ static int hvmemul_do_io( p = vio->io_req; /* Verify the emulation request has been correctly re-issued */ - if ( (p.type != is_mmio ? IOREQ_TYPE_COPY : IOREQ_TYPE_PIO) || + if ( (p.type != (is_mmio ? IOREQ_TYPE_COPY : IOREQ_TYPE_PIO)) || (p.addr != addr) || (p.size != size) || (p.count != *reps) || -- 2.30.2